Revision: 9339
Author: [email protected]
Date: Tue Sep 20 04:30:18 2011
Log: Remove incorrect debug-code assertion.
We should not use slot address to find out the page. This does not work for
large pages.
Also this assertion is not always true (violated during incremental
marking).
[email protected]
TEST=mozilla/js1_5/extensions/regress-371636
Review URL: http://codereview.chromium.org/7981001
http://code.google.com/p/v8/source/detail?r=9339
Modified:
/branches/bleeding_edge/src/ia32/macro-assembler-ia32.cc
/branches/bleeding_edge/src/x64/macro-assembler-x64.cc
=======================================
--- /branches/bleeding_edge/src/ia32/macro-assembler-ia32.cc Tue Sep 20
04:20:00 2011
+++ /branches/bleeding_edge/src/ia32/macro-assembler-ia32.cc Tue Sep 20
04:30:18 2011
@@ -84,12 +84,6 @@
SaveFPRegsMode save_fp,
MacroAssembler::RememberedSetFinalAction and_then) {
Label done;
- if (FLAG_debug_code) {
- Label ok;
- JumpIfNotInNewSpace(addr, scratch, &ok, Label::kNear);
- int3();
- bind(&ok);
- }
// Load store buffer top.
ExternalReference store_buffer =
ExternalReference::store_buffer_top(isolate());
=======================================
--- /branches/bleeding_edge/src/x64/macro-assembler-x64.cc Tue Sep 20
04:20:00 2011
+++ /branches/bleeding_edge/src/x64/macro-assembler-x64.cc Tue Sep 20
04:30:18 2011
@@ -201,12 +201,6 @@
Register scratch,
SaveFPRegsMode save_fp,
RememberedSetFinalAction
and_then) {
- if (FLAG_debug_code) {
- Label ok;
- JumpIfNotInNewSpace(addr, scratch, &ok, Label::kNear);
- int3();
- bind(&ok);
- }
// Load store buffer top.
LoadRoot(scratch, Heap::kStoreBufferTopRootIndex);
// Store pointer to buffer.
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
