LGTM
http://codereview.chromium.org/7983001/diff/1/src/spaces.cc File src/spaces.cc (right): http://codereview.chromium.org/7983001/diff/1/src/spaces.cc#newcode929 src/spaces.cc:929: ASSERT(static_cast<size_t>(Page::kPageSize) > OS::AllocateAlignment()); I don't think we really need this assert here. There are checks in routines that deal with virtual memory. http://codereview.chromium.org/7983001/diff/1/src/spaces.cc#newcode930 src/spaces.cc:930: int new_capacity = Min(MaximumCapacity(), 2 * static_cast<int>(Capacity())); We should ensure that MaxCapacity & Capacity is _always_ kPageSize aligned. That would clean the code (e.g. Rounding would not be needed here). And I really would expect that capacities are always aligned as we are managing new space with kPageSize granularity. http://codereview.chromium.org/7983001/diff/1/src/spaces.cc#newcode949 src/spaces.cc:949: ASSERT(static_cast<size_t>(Page::kPageSize) > OS::AllocateAlignment()); I don't think we really need this assert here. There are checks in routines that deal with virtual memory. http://codereview.chromium.org/7983001/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
