Reviewers: Vyacheslav Egorov, Description: Don't take heap snapshot when doing Heap::RecordStats from OOM cases.
Filled issue 1718 to track this. Please review this at http://codereview.chromium.org/7995003/ SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ Affected files: M src/api.cc Index: src/api.cc =================================================================== --- src/api.cc (revision 9396) +++ src/api.cc (working copy) @@ -185,7 +185,10 @@ int end_marker; heap_stats.end_marker = &end_marker; i::Isolate* isolate = i::Isolate::Current(); - isolate->heap()->RecordStats(&heap_stats, take_snapshot); + // BUG(1718): + // Don't use the take_snapshot since we don't support HeapIterator in new + // gc. + isolate->heap()->RecordStats(&heap_stats, false); i::V8::SetFatalError(); FatalErrorCallback callback = GetFatalErrorHandler(); { -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
