Revision: 9397
Author: [email protected]
Date: Thu Sep 22 07:43:23 2011
Log: Don't take heap snapshot when doing Heap::RecordStats from OOM
cases.
Filled issue 1718 to track this.
Review URL: http://codereview.chromium.org/7995003
http://code.google.com/p/v8/source/detail?r=9397
Modified:
/branches/bleeding_edge/src/api.cc
=======================================
--- /branches/bleeding_edge/src/api.cc Thu Sep 22 06:54:53 2011
+++ /branches/bleeding_edge/src/api.cc Thu Sep 22 07:43:23 2011
@@ -185,7 +185,10 @@
int end_marker;
heap_stats.end_marker = &end_marker;
i::Isolate* isolate = i::Isolate::Current();
- isolate->heap()->RecordStats(&heap_stats, take_snapshot);
+ // BUG(1718):
+ // Don't use the take_snapshot since we don't support HeapIterator here
+ // without doing a special GC.
+ isolate->heap()->RecordStats(&heap_stats, false);
i::V8::SetFatalError();
FatalErrorCallback callback = GetFatalErrorHandler();
{
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
