http://codereview.chromium.org/7987002/diff/1/test/preparser/strict-identifiers.pyt File test/preparser/strict-identifiers.pyt (right):
http://codereview.chromium.org/7987002/diff/1/test/preparser/strict-identifiers.pyt#newcode162 test/preparser/strict-identifiers.pyt:162: continue $id; On 2011/09/22 12:50:19, Lasse Reichstein wrote:
IIRC, you can't have break and continue outside of a loop. We should
check that
in the preparser too, so wrap these in a loop to ensure that it's only
the label
that can cause a failure.
Done. http://codereview.chromium.org/7987002/diff/1/test/preparser/strict-identifiers.pyt#newcode238 test/preparser/strict-identifiers.pyt:238: message = "strict_reserved_word" On 2011/09/22 12:50:19, Lasse Reichstein wrote:
Make a label_message = message here and in case three, but make them
different
for reserved_word == "const". Then use that as message for the
label_strict
test, and avoid duplicating lines unnecessarily.
Done. http://codereview.chromium.org/7987002/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
