LGTM, only nit

http://codereview.chromium.org/7995002/diff/1/src/arm/full-codegen-arm.cc
File src/arm/full-codegen-arm.cc (right):

http://codereview.chromium.org/7995002/diff/1/src/arm/full-codegen-arm.cc#newcode1522
src/arm/full-codegen-arm.cc:1522: __ push(r6);
maybe a comment here:
__ push(r6);  // Copy of array literal

http://codereview.chromium.org/7995002/diff/1/src/arm/stub-cache-arm.cc
File src/arm/stub-cache-arm.cc (right):

http://codereview.chromium.org/7995002/diff/1/src/arm/stub-cache-arm.cc#newcode4365
src/arm/stub-cache-arm.cc:4365: elements_reg,
Operand(FixedArray::kHeaderSize - kHeapObjectTag));
Nit: move last argument to next line

http://codereview.chromium.org/7995002/

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to