a little clarification
http://codereview.chromium.org/8002019/diff/1/src/hydrogen.cc File src/hydrogen.cc (right): http://codereview.chromium.org/8002019/diff/1/src/hydrogen.cc#newcode4007 src/hydrogen.cc:4007: HInstruction* HGraphBuilder::BuildFastElementAccess(HValue* elements, "not last last one" should read "the returned instruction" On 2011/09/23 09:05:24, danno wrote:
I find it a little asymmetric that BuildFirstElementAccess adds the
SmiCheck,
but not the last one. Maybe instead it should always to the
AddInstruction for
the result instruction, and return a HValue* (or NULL for stores)?
http://codereview.chromium.org/8002019/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
