LGTM, with comments.
http://codereview.chromium.org/7992003/diff/3001/src/x64/ic-x64.cc File src/x64/ic-x64.cc (right): http://codereview.chromium.org/7992003/diff/3001/src/x64/ic-x64.cc#newcode696 src/x64/ic-x64.cc:696: if (FLAG_smi_only_arrays) { The JumpIfNotSmi can be moved above the guard, together with the movq and ret for the two smi cases (now made one case). I think this speeds and simplifies the code. http://codereview.chromium.org/7992003/diff/3001/src/x64/stub-cache-x64.cc File src/x64/stub-cache-x64.cc (right): http://codereview.chromium.org/7992003/diff/3001/src/x64/stub-cache-x64.cc#newcode1522 src/x64/stub-cache-x64.cc:1522: __ movq(rcx, Operand(rsp, argc * kPointerSize)); Is this move to rcx now a dead value? If so, remove it. http://codereview.chromium.org/7992003/diff/3001/test/mjsunit/element-kind.js File test/mjsunit/element-kind.js (right): http://codereview.chromium.org/7992003/diff/3001/test/mjsunit/element-kind.js#newcode117 test/mjsunit/element-kind.js:117: assertKind(element_kind.fast_double_elements, fast_double_array); Why is the test for fast double elements in the change porting fast smi elements? http://codereview.chromium.org/7992003/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
