LGTM
http://codereview.chromium.org/8008016/diff/1/src/arm/ic-arm.cc File src/arm/ic-arm.cc (right): http://codereview.chromium.org/8008016/diff/1/src/arm/ic-arm.cc#newcode1367 src/arm/ic-arm.cc:1367: __ add(address, elements, fits on one line http://codereview.chromium.org/8008016/diff/1/src/arm/ic-arm.cc#newcode1375 src/arm/ic-arm.cc:1375: // Make sure the elements are smi-only. Comment seems wrong now, that is not what we check anymore. Probably something like: // If this is a smi only array call runtime. (or be more generic if you like, this might not be Danno's last array type specialization :-) ) http://codereview.chromium.org/8008016/diff/1/src/ia32/ic-ia32.cc File src/ia32/ic-ia32.cc (right): http://codereview.chromium.org/8008016/diff/1/src/ia32/ic-ia32.cc#newcode821 src/ia32/ic-ia32.cc:821: if (FLAG_smi_only_arrays) { Move (corrected) comment from ic-arm.cc in here http://codereview.chromium.org/8008016/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
