Feedback addressed, landing.
http://codereview.chromium.org/8017003/diff/8001/src/objects.cc File src/objects.cc (right): http://codereview.chromium.org/8017003/diff/8001/src/objects.cc#newcode6509 src/objects.cc:6509: // Verify target. On 2011/09/23 13:49:23, Vyacheslav Egorov wrote:
Can we avoid code duplication by moving these asserts + *RawField() =
this to
some auxiliary helper?
Done. http://codereview.chromium.org/8017003/diff/8001/src/objects.cc#newcode6570 src/objects.cc:6570: for (int i = 0; i < array->length(); ++i) { On 2011/09/23 13:49:23, Vyacheslav Egorov wrote:
Probably you can discard this transition altogether when all maps are
discarded.
(it will be picked up by the next GC).
Done. http://codereview.chromium.org/8017003/diff/8001/src/objects.cc#newcode6579 src/objects.cc:6579: // Getter prototype() is read-only, set_prototype() has side effects. On 2011/09/23 13:49:23, Vyacheslav Egorov wrote:
long line
Done. http://codereview.chromium.org/8017003/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
