LGTM
http://codereview.chromium.org/7977001/diff/8002/src/handles.h File src/handles.h (right): http://codereview.chromium.org/7977001/diff/8002/src/handles.h#newcode384 src/handles.h:384: Could we have a small comment (as in a executive summary of the one in heap.h :-)) One could easily wonder if this is a synchronization mechanism or a GC prevent move of this string functionality http://codereview.chromium.org/7977001/diff/8002/src/handles.h#newcode385 src/handles.h:385: void LockString(Handle<String> string); Any reason not to have this as a private method in StringLock? http://codereview.chromium.org/7977001/diff/8002/src/json-parser.h File src/json-parser.h (right): http://codereview.chromium.org/7977001/diff/8002/src/json-parser.h#newcode619 src/json-parser.h:619: add blank line http://codereview.chromium.org/7977001/diff/8002/src/json-parser.h#newcode624 src/json-parser.h:624: add blank line http://codereview.chromium.org/7977001/diff/8002/src/json-parser.h#newcode631 src/json-parser.h:631: add blank line http://codereview.chromium.org/7977001/diff/8002/src/json-parser.h#newcode644 src/json-parser.h:644: add blank line http://codereview.chromium.org/7977001/diff/8002/src/json-parser.h#newcode649 src/json-parser.h:649: add blank line http://codereview.chromium.org/7977001/diff/8002/src/json-parser.h#newcode654 src/json-parser.h:654: add blank line http://codereview.chromium.org/7977001/diff/8002/test/cctest/test-api.cc File test/cctest/test-api.cc (right): http://codereview.chromium.org/7977001/diff/8002/test/cctest/test-api.cc#newcode15428 test/cctest/test-api.cc:15428: // Unlock the first half again more. remove more from comment? http://codereview.chromium.org/7977001/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
