Reviewers: danno,
Description:
Disable compaction.
Introduce flag to control code compaction.
[email protected]
Please review this at http://codereview.chromium.org/8037022/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/flag-definitions.h
M src/mark-compact.cc
Index: src/flag-definitions.h
diff --git a/src/flag-definitions.h b/src/flag-definitions.h
index
358d67e472fdcd7424d9a5d87a666efab1d45997..654c32271ba5f02b24d77a6bb98f2a5174ba95b9
100644
--- a/src/flag-definitions.h
+++ b/src/flag-definitions.h
@@ -287,8 +287,9 @@ DEFINE_bool(lazy_sweeping, true,
"Use lazy sweeping for old pointer and data spaces")
DEFINE_bool(cleanup_caches_in_maps_at_gc, true,
"Flush code caches in maps during mark compact cycle.")
-DEFINE_bool(never_compact, false,
+DEFINE_bool(never_compact, true,
"Never perform compaction on full GC - testing only")
+DEFINE_bool(compact_code_space, true, "Compact code space")
DEFINE_bool(cleanup_code_caches_at_gc, true,
"Flush inline caches prior to mark compact collection and "
"flush code caches in maps during mark compact cycle.")
Index: src/mark-compact.cc
diff --git a/src/mark-compact.cc b/src/mark-compact.cc
index
fdc7edc59745c7ce3c99b4c74f790c76d3ac5837..07e490ed022d92b7c831cb46d8424dab53d98550
100644
--- a/src/mark-compact.cc
+++ b/src/mark-compact.cc
@@ -245,7 +245,10 @@ bool MarkCompactCollector::StartCompaction() {
CollectEvacuationCandidates(heap()->old_pointer_space());
CollectEvacuationCandidates(heap()->old_data_space());
- CollectEvacuationCandidates(heap()->code_space());
+
+ if (FLAG_compact_code_space) {
+ CollectEvacuationCandidates(heap()->code_space());
+ }
heap()->old_pointer_space()->EvictEvacuationCandidatesFromFreeLists();
heap()->old_data_space()->EvictEvacuationCandidatesFromFreeLists();
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
