Reviewers: Erik Corry,
Description:
Enable compaction, disable code-compaction.
Enable array-join test again.
[email protected]
Please review this at http://codereview.chromium.org/8043022/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/flag-definitions.h
M src/mark-compact.cc
M test/mjsunit/mjsunit.status
Index: src/flag-definitions.h
diff --git a/src/flag-definitions.h b/src/flag-definitions.h
index
654c32271ba5f02b24d77a6bb98f2a5174ba95b9..6c39f57170faada733504a81478d65eaa1e35924
100644
--- a/src/flag-definitions.h
+++ b/src/flag-definitions.h
@@ -287,9 +287,9 @@ DEFINE_bool(lazy_sweeping, true,
"Use lazy sweeping for old pointer and data spaces")
DEFINE_bool(cleanup_caches_in_maps_at_gc, true,
"Flush code caches in maps during mark compact cycle.")
-DEFINE_bool(never_compact, true,
+DEFINE_bool(never_compact, false,
"Never perform compaction on full GC - testing only")
-DEFINE_bool(compact_code_space, true, "Compact code space")
+DEFINE_bool(compact_code_space, false, "Compact code space")
DEFINE_bool(cleanup_code_caches_at_gc, true,
"Flush inline caches prior to mark compact collection and "
"flush code caches in maps during mark compact cycle.")
Index: src/mark-compact.cc
diff --git a/src/mark-compact.cc b/src/mark-compact.cc
index
4526d1220571439a11f957a554d8b0b6c9d14c0d..b90ecf0698a53bbc8fe348064a1b23793e018b3a
100644
--- a/src/mark-compact.cc
+++ b/src/mark-compact.cc
@@ -485,7 +485,7 @@ void MarkCompactCollector::Prepare(GCTracer* tracer) {
#endif
// TODO(1726) Revert this into an assertion when compaction is enabled.
- if (FLAG_never_compact) FLAG_always_compact = false;
+ ASSERT(!FLAG_never_compact || !FLAG_always_compact);
if (collect_maps_) CreateBackPointers();
#ifdef ENABLE_GDB_JIT_INTERFACE
Index: test/mjsunit/mjsunit.status
diff --git a/test/mjsunit/mjsunit.status b/test/mjsunit/mjsunit.status
index
966fe0a7e7cb2f236e6dc3e63f500812ba8981c2..d2511b25db5eb79a42b99bceb7d534810fa80438
100644
--- a/test/mjsunit/mjsunit.status
+++ b/test/mjsunit/mjsunit.status
@@ -35,9 +35,6 @@ bugs: FAIL
regress/regress-1119: FAIL
##############################################################################
-# NewGC: http://code.google.com/p/v8/issues/detail?id=1701
-array-join: SKIP
-
# NewGC: BUG(1719) slow to collect arrays over several contexts.
regress/regress-524: SKIP
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
