LGTM, but I have one suggestion for improvement below.
http://codereview.chromium.org/8054008/diff/1/src/hydrogen-instructions.h File src/hydrogen-instructions.h (right): http://codereview.chromium.org/8054008/diff/1/src/hydrogen-instructions.h#newcode3204 src/hydrogen-instructions.h:3204: HLoadGlobalCell(Handle<JSGlobalPropertyCell> cell, bool deleteable_or_const) I'm not thrilled with the bool. The terminology is also confusing by now. We have a mix of "(not) read only" / "(not) don't delete" in older code and "(not) writable" / "(not) configurable" in newer code. One suggestion is to store the PropertyAttributes from the lookup: new(zone()) HLoadGlobalCell(cell, lookup.GetAttributes()) And then use them in RequiresHoleCheck(). That should take up the same amount of space and be more flexible. http://codereview.chromium.org/8054008/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
