Reviewers: Søren Gjesse,
Message:
The test case for the debugger deadlock led unexpectedly to test failures
on the
buildbots that can't be reproduced locally. So I opted for a more basic test
instead.
Description:
Fixing test case from r9469.
Please review this at http://codereview.chromium.org/8038046/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M test/cctest/test-debug.cc
M test/cctest/test-threads.cc
Index: test/cctest/test-debug.cc
diff --git a/test/cctest/test-debug.cc b/test/cctest/test-debug.cc
index
2383f2dd09fb9926ebe5cbc4078290b4c9348585..4cfbf9480f867089ea81204b9ee2b06ecf39830a
100644
--- a/test/cctest/test-debug.cc
+++ b/test/cctest/test-debug.cc
@@ -5888,27 +5888,6 @@ TEST(DebuggerAgent) {
debugger->StopAgent();
delete server;
-
- // Test responsiveness after connecting and disconnecting a client.
- ok = debugger->StartAgent("test", kPort4);
- CHECK(ok);
- client = i::OS::CreateSocket();
- ok = client->Connect("localhost", port4_str);
- CHECK(ok);
- ok = client->Receive(&buf, 1) == 1;
- CHECK(ok);
- ok = client->Send(
- "{\"seq\":1,\"type\":\"request\",\"command\":\"disconnect\"}", 49);
- CHECK(ok);
- client->Shutdown();
- delete client;
- // Is the server still responsive?
- client = i::OS::CreateSocket();
- ok = client->Connect("localhost", port4_str);
- CHECK(ok);
- client->Shutdown();
- delete client;
- debugger->StopAgent();
}
Index: test/cctest/test-threads.cc
diff --git a/test/cctest/test-threads.cc b/test/cctest/test-threads.cc
index
e1a48ae53f9a2e5536dd8d986edb9bfaae5f14f3..463be7b500a8f2fe73ab56b7fd58b6b77586deca
100644
--- a/test/cctest/test-threads.cc
+++ b/test/cctest/test-threads.cc
@@ -190,3 +190,19 @@ TEST(ThreadIdValidation) {
delete threads[i];
}
}
+
+
+class ThreadC: public v8::internal::Thread {
+ public:
+ ThreadC() : Thread("ThreadC") { }
+ void Run() {
+ Join();
+ }
+};
+
+
+TEST(ThreadJoinSelf) {
+ ThreadC thread;
+ thread.Start();
+ thread.Join();
+}
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
