Revision: 9473
Author: [email protected]
Date: Wed Sep 28 07:26:23 2011
Log: Fixing test case from r9469.
Review URL: http://codereview.chromium.org/8038046
http://code.google.com/p/v8/source/detail?r=9473
Modified:
/branches/bleeding_edge/test/cctest/test-debug.cc
/branches/bleeding_edge/test/cctest/test-threads.cc
=======================================
--- /branches/bleeding_edge/test/cctest/test-debug.cc Wed Sep 28 06:27:20
2011
+++ /branches/bleeding_edge/test/cctest/test-debug.cc Wed Sep 28 07:26:23
2011
@@ -5845,14 +5845,11 @@
const int kPort1 = 5858;
const int kPort2 = 5857;
const int kPort3 = 5856;
- const int kPort4 = 5855;
// Make a string with the port2 number.
const int kPortBufferLen = 6;
char port2_str[kPortBufferLen];
OS::SNPrintF(i::Vector<char>(port2_str, kPortBufferLen), "%d", kPort2);
- char port4_str[kPortBufferLen];
- OS::SNPrintF(i::Vector<char>(port4_str, kPortBufferLen), "%d", kPort4);
bool ok;
@@ -5888,27 +5885,6 @@
debugger->StopAgent();
delete server;
-
- // Test responsiveness after connecting and disconnecting a client.
- ok = debugger->StartAgent("test", kPort4);
- CHECK(ok);
- client = i::OS::CreateSocket();
- ok = client->Connect("localhost", port4_str);
- CHECK(ok);
- ok = client->Receive(&buf, 1) == 1;
- CHECK(ok);
- ok = client->Send(
- "{\"seq\":1,\"type\":\"request\",\"command\":\"disconnect\"}", 49);
- CHECK(ok);
- client->Shutdown();
- delete client;
- // Is the server still responsive?
- client = i::OS::CreateSocket();
- ok = client->Connect("localhost", port4_str);
- CHECK(ok);
- client->Shutdown();
- delete client;
- debugger->StopAgent();
}
=======================================
--- /branches/bleeding_edge/test/cctest/test-threads.cc Mon Sep 19 11:36:47
2011
+++ /branches/bleeding_edge/test/cctest/test-threads.cc Wed Sep 28 07:26:23
2011
@@ -63,7 +63,7 @@
static Turn turn = FILL_CACHE;
-class ThreadA: public v8::internal::Thread {
+class ThreadA : public v8::internal::Thread {
public:
ThreadA() : Thread("ThreadA") { }
void Run() {
@@ -99,7 +99,7 @@
};
-class ThreadB: public v8::internal::Thread {
+class ThreadB : public v8::internal::Thread {
public:
ThreadB() : Thread("ThreadB") { }
void Run() {
@@ -190,3 +190,19 @@
delete threads[i];
}
}
+
+
+class ThreadC : public v8::internal::Thread {
+ public:
+ ThreadC() : Thread("ThreadC") { }
+ void Run() {
+ Join();
+ }
+};
+
+
+TEST(ThreadJoinSelf) {
+ ThreadC thread;
+ thread.Start();
+ thread.Join();
+}
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
