http://codereview.chromium.org/8115014/diff/1/src/platform-linux.cc File src/platform-linux.cc (right):
http://codereview.chromium.org/8115014/diff/1/src/platform-linux.cc#newcode459 src/platform-linux.cc:459: mmap(GetRandomMmapAddr(), size, PROT_READ | PROT_WRITE, preferred formatting is one arguments per line http://codereview.chromium.org/8115014/diff/1/src/platform-linux.cc#newcode475 src/platform-linux.cc:475: mmap(GetRandomMmapAddr(), size, PROT_READ | PROT_WRITE, ditto http://codereview.chromium.org/8115014/diff/1/src/platform-linux.cc#newcode561 src/platform-linux.cc:561: void* addr = mmap(GetRandomMmapAddr(), size, PROT_READ | PROT_EXEC, ditto http://codereview.chromium.org/8115014/diff/1/src/platform-macos.cc File src/platform-macos.cc (right): http://codereview.chromium.org/8115014/diff/1/src/platform-macos.cc#newcode95 src/platform-macos.cc:95: static void* GetRandomMmapAddr() { consider moving somewhere (e.g. platfrom-posix.cc) to avoid duplication. platform can define the range of unpopular addresses which shared implementation would use. http://codereview.chromium.org/8115014/diff/1/src/platform-macos.cc#newcode169 src/platform-macos.cc:169: void* mbase = mmap(GetRandomMmapAddr(), msize, prot, formatting: one argument per line http://codereview.chromium.org/8115014/diff/1/src/platform-macos.cc#newcode228 src/platform-macos.cc:228: mmap(GetRandomMmapAddr(), size, PROT_READ | PROT_WRITE, formatting: one argument per line http://codereview.chromium.org/8115014/diff/1/src/platform-macos.cc#newcode244 src/platform-macos.cc:244: mmap(GetRandomMmapAddr(), size, PROT_READ | PROT_WRITE, formatting: one argument per line http://codereview.chromium.org/8115014/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
