Reviewers: Vyacheslav Egorov,
http://codereview.chromium.org/8130002/diff/1/src/heap.cc
File src/heap.cc (right):
http://codereview.chromium.org/8130002/diff/1/src/heap.cc#newcode1813
src/heap.cc:1813: set_undefined_value(Oddball::cast(obj));
heap->undefined_value() is used by CreateApiObjects, which does
AllocateJSObjectFromMap which calls AllocateFixedArray.
http://codereview.chromium.org/8130002/diff/1/src/isolate.cc
File src/isolate.cc (right):
http://codereview.chromium.org/8130002/diff/1/src/isolate.cc#newcode1772
src/isolate.cc:1772: InitializeThreadLocal();
Calls clear_pending_exception() which uses heap->the_hole_value().
The oddballs are only initialized after deserialization.
Description:
Make accessors for oddball objects return Oddball* instead of Object*.
Fix a use of the hole value and the undefined value before initialization
when
initializing V8. Before we just read a NULL value from them.
Please review this at http://codereview.chromium.org/8130002/
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected files:
M src/compiler.cc
M src/debug.cc
M src/heap.h
M src/heap.cc
M src/hydrogen.cc
M src/ic.cc
M src/isolate.cc
M src/messages.cc
M src/objects.h
M src/objects.cc
M src/type-info.h
M src/type-info.cc
src/v8utils.h
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
