Reviewers: Erik Corry,
Description:
Adjust contents of kAheadOfTime to match write-barrier stub called from
CompileArrayPushCall.
[email protected]
BUG=v8:1729
Please review this at http://codereview.chromium.org/8113034/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/ia32/code-stubs-ia32.cc
M tools/gcmole/gccause.lua
Index: src/ia32/code-stubs-ia32.cc
diff --git a/src/ia32/code-stubs-ia32.cc b/src/ia32/code-stubs-ia32.cc
index
00265dd7178a5eaa6507961df2850435c1313ee6..ede13e2a1539427b448772a95d527b29609e80fd
100644
--- a/src/ia32/code-stubs-ia32.cc
+++ b/src/ia32/code-stubs-ia32.cc
@@ -6676,6 +6676,7 @@ struct AheadOfTimeWriteBarrierStubList kAheadOfTime[]
= {
{ ebx, eax, edi, EMIT_REMEMBERED_SET },
// Used in CompileArrayPushCall.
{ ebx, ecx, edx, EMIT_REMEMBERED_SET },
+ { ebx, edi, edx, OMIT_REMEMBERED_SET },
// Used in CompileStoreGlobal and CallFunctionStub.
{ ebx, ecx, edx, OMIT_REMEMBERED_SET },
// Used in StoreStubCompiler::CompileStoreField and
@@ -6684,7 +6685,7 @@ struct AheadOfTimeWriteBarrierStubList kAheadOfTime[]
= {
// GenerateStoreField calls the stub with two different permutations of
// registers. This is the second.
{ ebx, ecx, edx, EMIT_REMEMBERED_SET },
- // StoreIC::GenerateNormal via GenerateDictionaryStore,
CompileArrayPushCall
+ // StoreIC::GenerateNormal via GenerateDictionaryStore
{ ebx, edi, edx, EMIT_REMEMBERED_SET },
// KeyedStoreIC::GenerateGeneric.
{ ebx, edx, ecx, EMIT_REMEMBERED_SET},
Index: tools/gcmole/gccause.lua
diff --git a/tools/gcmole/gccause.lua b/tools/gcmole/gccause.lua
index
a6fe5421374a6b4acfc61045cc2a03d493bb404d..b9891767de390eb559393c71f45fb400de036029
100644
--- a/tools/gcmole/gccause.lua
+++ b/tools/gcmole/gccause.lua
@@ -48,6 +48,8 @@ local function TrackCause(name, lvl)
T[f] = true
TrackCause(f, (lvl or 0) + 1)
end
+
+ if f == '<GC>' then break end
end
end
end
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
