http://codereview.chromium.org/8130002/diff/1/src/debug.cc File src/debug.cc (right):
http://codereview.chromium.org/8130002/diff/1/src/debug.cc#newcode2161 src/debug.cc:2161: reinterpret_cast<Object**>(uncaught ? factory->true_value().location() : On 2011/10/04 11:00:51, Vyacheslav Egorov wrote:
line is too long, also consider making Factory::ToBoolean analogue of Heap::ToBoolean
Done. http://codereview.chromium.org/8130002/diff/1/src/debug.cc#newcode2188 src/debug.cc:2188: reinterpret_cast<Object**>(before ? factory->true_value().location() : On 2011/10/04 11:00:51, Vyacheslav Egorov wrote:
line is too long, also consider making Factory::ToBoolean analogue of Heap::ToBoolean
Done. http://codereview.chromium.org/8130002/diff/1/src/heap.cc File src/heap.cc (right): http://codereview.chromium.org/8130002/diff/1/src/heap.cc#newcode2210 src/heap.cc:2210: undefined_value()->Initialize("undefined", nan_value(), Oddball::kUndefined); On 2011/10/04 11:00:51, Vyacheslav Egorov wrote:
long line
Done. http://codereview.chromium.org/8130002/diff/1/src/type-info.cc File src/type-info.cc (right): http://codereview.chromium.org/8130002/diff/1/src/type-info.cc#newcode76 src/type-info.cc:76: : Handle<Object>::cast(Isolate::Current()->factory()->undefined_value()); On 2011/10/04 11:00:51, Vyacheslav Egorov wrote:
you have isolate_ now
Done. Of course, I totally forgot about that :) http://codereview.chromium.org/8130002/diff/1/src/v8utils.h File src/v8utils.h (right): http://codereview.chromium.org/8130002/diff/1/src/v8utils.h#newcode146 src/v8utils.h:146: static inline void MemsetPointer(T** dest, U* value, int counter) { On 2011/10/04 11:00:51, Vyacheslav Egorov wrote:
well. this one is spooky.
at least at assignability check to T to U (it will not be checked if
we are
generating inline assembly).
(see Handle constructor in handles.h on how to check assignability).
Done. http://codereview.chromium.org/8130002/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
