http://codereview.chromium.org/8124025/diff/1/test/mjsunit/array-tostring.js File test/mjsunit/array-tostring.js (right):
http://codereview.chromium.org/8124025/diff/1/test/mjsunit/array-tostring.js#newcode78 test/mjsunit/array-tostring.js:78: Add comment on what we are testing, e.g., // Check that setting join on a normal object works. http://codereview.chromium.org/8124025/diff/1/test/mjsunit/array-tostring.js#newcode85 test/mjsunit/array-tostring.js:85: One more comment?: // Check that when join is not callable we fallback to the normal tostring on the actual object passed in http://codereview.chromium.org/8124025/diff/1/test/mjsunit/array-tostring.js#newcode104 test/mjsunit/array-tostring.js:104: assertFalse(called_before); indention here seems random http://codereview.chromium.org/8124025/diff/1/test/mjsunit/array-tostring.js#newcode110 test/mjsunit/array-tostring.js:110: assertEquals(success, 42..arrayToString()); Please add parenthesis around 42 to increase readability http://codereview.chromium.org/8124025/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
