Reviewers: Vyacheslav Egorov,
Description:
Add a regression test for an already fixed issue.
Add a regression test for Chromium issue 99167.
[email protected]
BUG=
TEST=
Please review this at http://codereview.chromium.org/8222002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/heap.cc
A test/mjsunit/regress/regress-99167.js
Index: src/heap.cc
diff --git a/src/heap.cc b/src/heap.cc
index
b40b8208df4401adfb37afc80fb3c725e20271d5..35264b9085628ab62ebb6747321aa81bf486ed38
100644
--- a/src/heap.cc
+++ b/src/heap.cc
@@ -5065,7 +5065,7 @@ bool Heap::ConfigureHeap(int max_semispace_size,
if (max_semispace_size < Page::kPageSize) {
max_semispace_size = Page::kPageSize;
if (FLAG_trace_gc) {
- PrintF("Max semispace size cannot be less than %dkbytes",
+ PrintF("Max semispace size cannot be less than %dkbytes\n",
Page::kPageSize >> 10);
}
}
@@ -5081,7 +5081,7 @@ bool Heap::ConfigureHeap(int max_semispace_size,
if (max_semispace_size_ > reserved_semispace_size_) {
max_semispace_size_ = reserved_semispace_size_;
if (FLAG_trace_gc) {
- PrintF("Max semispace size cannot be more than %dkbytes",
+ PrintF("Max semispace size cannot be more than %dkbytes\n",
reserved_semispace_size_ >> 10);
}
}
Index: test/mjsunit/regress/regress-99167.js
diff --git a/test/mjsunit/regress/regress-99167.js
b/test/mjsunit/regress/regress-99167.js
new file mode 100644
index
0000000000000000000000000000000000000000..5053ae5d24f5766e6d3116456fae305427196be5
--- /dev/null
+++ b/test/mjsunit/regress/regress-99167.js
@@ -0,0 +1,33 @@
+// Copyright 2011 the V8 project authors. All rights reserved.
+// Redistribution and use in source and binary forms, with or without
+// modification, are permitted provided that the following conditions are
+// met:
+//
+// * Redistributions of source code must retain the above copyright
+// notice, this list of conditions and the following disclaimer.
+// * Redistributions in binary form must reproduce the above
+// copyright notice, this list of conditions and the following
+// disclaimer in the documentation and/or other materials provided
+// with the distribution.
+// * Neither the name of Google Inc. nor the names of its
+// contributors may be used to endorse or promote products derived
+// from this software without specific prior written permission.
+//
+// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+// "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+// LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+// A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+// OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+// SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+// LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+// DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+// THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+
+// Flags: --expose-gc --max-new-space-size=1024
+
+eval("function Node() { this.a = 1; this.a = 3; }");
+new Node;
+for (var i = 0; i < 4; ++i) gc();
+for (var i = 0; i < 100000; ++i) new Node;
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
