addressed feedback and landed
http://codereview.chromium.org/8177005/diff/1/src/builtins.cc File src/builtins.cc (right): http://codereview.chromium.org/8177005/diff/1/src/builtins.cc#newcode413 src/builtins.cc:413: MaybeObject* maybe_writable_result = array->EnsureWritableFastElements(); On 2011/10/07 17:58:13, Jakob wrote:
nit: excess space after =
Done. http://codereview.chromium.org/8177005/diff/1/src/builtins.cc#newcode414 src/builtins.cc:414: if (maybe_writable_result->IsFailure()) return maybe_writable_result; On 2011/10/07 17:58:13, Jakob wrote:
You don't need this line (it's included in the next condition anyway).
Done. http://codereview.chromium.org/8177005/diff/1/src/objects-inl.h File src/objects-inl.h (right): http://codereview.chromium.org/8177005/diff/1/src/objects-inl.h#newcode1658 src/objects-inl.h:1658: static int foo = 0; On 2011/10/07 17:58:13, Jakob wrote:
debugging leftover?
Done. http://codereview.chromium.org/8177005/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
