LGTM with comments.
http://codereview.chromium.org/8221004/diff/1/src/parser.cc File src/parser.cc (left): http://codereview.chromium.org/8221004/diff/1/src/parser.cc#oldcode1691 src/parser.cc:1691: Scope* declaration_scope = mode == Variable::LET Consider adding brackets here for better readability. http://codereview.chromium.org/8221004/diff/1/src/parser.cc#oldcode1882 src/parser.cc:1882: bool in_with = mode == Variable::VAR ? inside_with() : false; Consider brackets. http://codereview.chromium.org/8221004/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
