Reviewers: Rico,
Description:
Remove some unused and unneeded flags.
Please review this at http://codereview.chromium.org/8228004/
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected files:
M benchmarks/spinning-balls/v.js
M src/arm/code-stubs-arm.cc
M src/flag-definitions.h
M src/ia32/code-stubs-ia32.cc
M src/mips/code-stubs-mips.cc
M src/spaces.h
M src/x64/code-stubs-x64.cc
Index: benchmarks/spinning-balls/v.js
===================================================================
--- benchmarks/spinning-balls/v.js (revision 9575)
+++ benchmarks/spinning-balls/v.js (working copy)
@@ -42,6 +42,9 @@
} )();
}
+
+
+
var kNPoints = 8000;
var kNModifications = 20;
var kNVisiblePoints = 200;
@@ -54,11 +57,23 @@
var dyingPoints = void 0;
var scene = void 0;
var renderingStartTime = void 0;
+var omitFrameDueToVisibilityChange = false;
var scene = void 0;
var pausePlot = void 0;
var splayTree = void 0;
+handleVisibilityChange();
+function handleVisibilityChange() {
+ console.log("visibility change");
+ omitFrameDueToVisibilityChange = true;
+ document.addEventListener("webkitvisibilitychange",
handleVisibilityChange);
+ document.addEventListener("msvisibilitychange", handleVisibilityChange);
+ document.addEventListener("mozvisibilitychange", handleVisibilityChange);
+ document.addEventListener("visibilitychange", handleVisibilityChange);
+}
+
+
function Point(x, y, z, payload) {
this.x = x;
this.y = y;
@@ -353,9 +368,12 @@
scene.draw();
var renderingEndTime = Date.now();
- var pause = renderingEndTime - renderingStartTime;
- pausePlot.addPause(pause);
+ if (!omitFrameDueToVisibilityChange) {
+ var pause = renderingEndTime - renderingStartTime;
+ pausePlot.addPause(pause);
+ }
renderingStartTime = renderingEndTime;
+ omitFrameDueToVisibilityChange = false;
pausePlot.draw();
Index: src/arm/code-stubs-arm.cc
===================================================================
--- src/arm/code-stubs-arm.cc (revision 9575)
+++ src/arm/code-stubs-arm.cc (working copy)
@@ -4426,10 +4426,6 @@
#ifdef V8_INTERPRETED_REGEXP
__ TailCallRuntime(Runtime::kRegExpExec, 4, 1);
#else // V8_INTERPRETED_REGEXP
- if (!FLAG_regexp_entry_native) {
- __ TailCallRuntime(Runtime::kRegExpExec, 4, 1);
- return;
- }
// Stack frame on entry.
// sp[0]: last_match_info (expected JSArray)
Index: src/flag-definitions.h
===================================================================
--- src/flag-definitions.h (revision 9575)
+++ src/flag-definitions.h (working copy)
@@ -300,9 +300,6 @@
DEFINE_bool(canonicalize_object_literal_maps, true,
"Canonicalize maps for object literals.")
-DEFINE_bool(use_big_map_space, true,
- "Use big map space, but don't compact if it grew too big.")
-
DEFINE_int(max_map_space_pages, MapSpace::kMaxMapPageIndex - 1,
"Maximum number of pages in map space which still allows to
encode "
"forwarding pointers. That's actually a constant, but it's
useful "
@@ -338,7 +335,6 @@
// Regexp
DEFINE_bool(regexp_optimization, true, "generate optimized regexp code")
-DEFINE_bool(regexp_entry_native, true, "use native code to enter regexp")
// Testing flags test/cctest/test-{flags,api,serialization}.cc
DEFINE_bool(testing_bool_flag, true, "testing_bool_flag")
@@ -465,9 +461,6 @@
DEFINE_bool(trace_isolates, false, "trace isolate state changes")
-DEFINE_bool(trace_live_byte_count, false,
- "trace updates to page live byte count")
-
// VM state
DEFINE_bool(log_state_changes, false, "Log state changes.")
Index: src/ia32/code-stubs-ia32.cc
===================================================================
--- src/ia32/code-stubs-ia32.cc (revision 9575)
+++ src/ia32/code-stubs-ia32.cc (working copy)
@@ -3384,10 +3384,6 @@
#ifdef V8_INTERPRETED_REGEXP
__ TailCallRuntime(Runtime::kRegExpExec, 4, 1);
#else // V8_INTERPRETED_REGEXP
- if (!FLAG_regexp_entry_native) {
- __ TailCallRuntime(Runtime::kRegExpExec, 4, 1);
- return;
- }
// Stack frame on entry.
// esp[0]: return address
Index: src/mips/code-stubs-mips.cc
===================================================================
--- src/mips/code-stubs-mips.cc (revision 9575)
+++ src/mips/code-stubs-mips.cc (working copy)
@@ -4471,10 +4471,6 @@
#ifdef V8_INTERPRETED_REGEXP
__ TailCallRuntime(Runtime::kRegExpExec, 4, 1);
#else // V8_INTERPRETED_REGEXP
- if (!FLAG_regexp_entry_native) {
- __ TailCallRuntime(Runtime::kRegExpExec, 4, 1);
- return;
- }
// Stack frame on entry.
// sp[0]: last_match_info (expected JSArray)
Index: src/spaces.h
===================================================================
--- src/spaces.h (revision 9575)
+++ src/spaces.h (working copy)
@@ -452,7 +452,7 @@
// Manage live byte count (count of bytes known to be live,
// because they are marked black).
void ResetLiveBytes() {
- if (FLAG_trace_live_byte_count) {
+ if (FLAG_gc_verbose) {
PrintF("ResetLiveBytes:%p:%x->0\n",
static_cast<void*>(this), live_byte_count_);
}
@@ -460,7 +460,7 @@
}
void IncrementLiveBytes(int by) {
ASSERT_LE(static_cast<unsigned>(live_byte_count_), size_);
- if (FLAG_trace_live_byte_count) {
+ if (FLAG_gc_verbose) {
printf("UpdateLiveBytes:%p:%x%c=%x->%x\n",
static_cast<void*>(this), live_byte_count_,
((by < 0) ? '-' : '+'), ((by < 0) ? -by : by),
Index: src/x64/code-stubs-x64.cc
===================================================================
--- src/x64/code-stubs-x64.cc (revision 9575)
+++ src/x64/code-stubs-x64.cc (working copy)
@@ -2438,10 +2438,6 @@
#ifdef V8_INTERPRETED_REGEXP
__ TailCallRuntime(Runtime::kRegExpExec, 4, 1);
#else // V8_INTERPRETED_REGEXP
- if (!FLAG_regexp_entry_native) {
- __ TailCallRuntime(Runtime::kRegExpExec, 4, 1);
- return;
- }
// Stack frame on entry.
// rsp[0]: return address
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
