lgtm with comments addressed
http://codereview.chromium.org/8234002/diff/5001/src/heap.h File src/heap.h (right): http://codereview.chromium.org/8234002/diff/5001/src/heap.h#newcode1249 src/heap.h:1249: static int divisor = 3; it does not have to be static. just have int divisor = FLAG_... ? 2 : 10 http://codereview.chromium.org/8234002/diff/5001/src/heap.h#newcode1259 src/heap.h:1259: static int divisor = 2; ditto http://codereview.chromium.org/8234002/diff/5001/src/mark-compact.cc File src/mark-compact.cc (right): http://codereview.chromium.org/8234002/diff/5001/src/mark-compact.cc#newcode433 src/mark-compact.cc:433: if (it.has_next()) it.next(); // Never compact the first page.A accidental edit http://codereview.chromium.org/8234002/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
