http://codereview.chromium.org/8226017/diff/1/src/v8.cc File src/v8.cc (right):
http://codereview.chromium.org/8226017/diff/1/src/v8.cc#newcode61 src/v8.cc:61: // TODO(rossberg): Is there a better place to put this? On 2011/10/12 11:54:38, Steven wrote:
This is indeed not such a cool place to put it. You could consider
putting it at
the end of FlagList::SetFlagsFromCommandLine in flags.cc or doing something in Shell::SetOptions in d8.cc. At least that would
group this
code with other options/flags code.
Well, I think flags.cc would be the wrong place to put it, since that should be generic and hence oblivious to individual flags. (It would also create a circular dependency, I suspect.) D8 is also the wrong place, because then it will only work for D8. ;-) Ideally, flags.cc would provide a generic way to express implications between flags. But that is clearly overkill at this point http://codereview.chromium.org/8226017/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
