LGTM.
I just ran some additional proxy tests against this patch, and it seems to
work
fine except for the length issue (see below).
http://codereview.chromium.org/8199004/diff/1/src/runtime.cc
File src/runtime.cc (right):
http://codereview.chromium.org/8199004/diff/1/src/runtime.cc#newcode7993
src/runtime.cc:7993: bindee = Execution::GetFunctionDelegate(bindee);
Unfortunately, that is not quite right for proxies. For a proxy, the
spec will probably require reading the length property from the proxy
itself (via the get trap), and if it's not a positive integer, default
to 0. That is what the current code does (although I just realised that
there is no test for that).
I guess that could be a TODO. Main annoyance is that with the new code,
that would have to be done in C++.
http://codereview.chromium.org/8199004/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
