On 2011/10/06 19:09:27, Steven wrote:
Thanks for the thorough review. I addressed all of your comments except
for
refactorings that should be done in another CL. I'm a bit concerned about
the
memory usage though. This change now stores the complete scope tree of a
function even though this information is only needed when debugging. And
there
we don't care about performance anyway. So instead I would really consider
what
we talked about earlier: reparsing the source and redoing the variable
resolution + allocation to recreate the scope tree. What do you think?
I think you've convinced me (to reparse and reconstruct scopes). It also
has
the advantage of being quite local.
http://codereview.chromium.org/7979001/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
