LGTM
http://codereview.chromium.org/7837028/diff/6017/src/parser.cc File src/parser.cc (right): http://codereview.chromium.org/7837028/diff/6017/src/parser.cc#newcode2437 src/parser.cc:2437: // TODO(keuchel): move temporary variable to block scope What does this mean? Is the current code not correct, or is this just an optimization? (and remember '.' at end of sentences :). http://codereview.chromium.org/7837028/diff/6017/test/mjsunit/harmony/block-for.js File test/mjsunit/harmony/block-for.js (right): http://codereview.chromium.org/7837028/diff/6017/test/mjsunit/harmony/block-for.js#newcode36 test/mjsunit/harmony/block-for.js:36: assertEquals(0, props({}).length, "olen0"); You can safely choose to omit the third parameter of the test without loss since our test framework reports the line now. http://codereview.chromium.org/7837028/diff/6017/test/mjsunit/harmony/block-for.js#newcode54 test/mjsunit/harmony/block-for.js:54: for (let i = 0x0020; i < 0x01ff; i+=2) { Try declaring i and s prior to this loop, and see that their values haven't changed afterwards. http://codereview.chromium.org/7837028/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
