Reviewers: Erik Corry,
Description:
Increase ARM/MIPS simulators stack safety margin to 512 bytes
R=erik.co...@gmail.com
BUG=v8:1773
Please review this at http://codereview.chromium.org/8337014/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/arm/simulator-arm.cc
M src/mips/simulator-mips.cc
Index: src/arm/simulator-arm.cc
diff --git a/src/arm/simulator-arm.cc b/src/arm/simulator-arm.cc
index
5704202622323fb9bc0776cf5d4c563b3bf73ff9..542cc302d30f09c8db016b977930181ae76304a8
100644
--- a/src/arm/simulator-arm.cc
+++ b/src/arm/simulator-arm.cc
@@ -1268,9 +1268,9 @@ void Simulator::WriteDW(int32_t addr, int32_t value1,
int32_t value2) {
// Returns the limit of the stack area to enable checking for stack
overflows.
uintptr_t Simulator::StackLimit() const {
- // Leave a safety margin of 256 bytes to prevent overrunning the stack
when
+ // Leave a safety margin of 512 bytes to prevent overrunning the stack
when
// pushing values.
- return reinterpret_cast<uintptr_t>(stack_) + 256;
+ return reinterpret_cast<uintptr_t>(stack_) + 512;
}
Index: src/mips/simulator-mips.cc
diff --git a/src/mips/simulator-mips.cc b/src/mips/simulator-mips.cc
index
17c18977c702fb42dd330b87571e2b4d80e8685d..0ec3e283c6617139a39387d80d8a1e83260e5a01
100644
--- a/src/mips/simulator-mips.cc
+++ b/src/mips/simulator-mips.cc
@@ -1359,9 +1359,9 @@ void Simulator::WriteB(int32_t addr, int8_t value) {
// Returns the limit of the stack area to enable checking for stack
overflows.
uintptr_t Simulator::StackLimit() const {
- // Leave a safety margin of 256 bytes to prevent overrunning the stack
when
+ // Leave a safety margin of 512 bytes to prevent overrunning the stack
when
// pushing values.
- return reinterpret_cast<uintptr_t>(stack_) + 256;
+ return reinterpret_cast<uintptr_t>(stack_) + 512;
}
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
