LGTM.
http://codereview.chromium.org/8334021/diff/1/src/hydrogen-instructions.cc File src/hydrogen-instructions.cc (right): http://codereview.chromium.org/8334021/diff/1/src/hydrogen-instructions.cc#newcode791 src/hydrogen-instructions.cc:791: return HasNoUses()&& !IsBlockEntry() ? NULL : this; Missing a space before &&, also below. http://codereview.chromium.org/8334021/diff/1/src/hydrogen.cc File src/hydrogen.cc (right): http://codereview.chromium.org/8334021/diff/1/src/hydrogen.cc#newcode5798 src/hydrogen.cc:5798: ast_context()->ReturnControl(instr, expr->id()); I like the "return". This function is (sort of) assumed to be called in tail position as part of translating an expression, so the return (sort of) enforces that. http://codereview.chromium.org/8334021/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
