LGTM with fix
http://codereview.chromium.org/8347032/diff/1/src/api.cc File src/api.cc (right): http://codereview.chromium.org/8347032/diff/1/src/api.cc#newcode4008 src/api.cc:4008: if (!isolate || !i::Isolate::Current()->IsInitialized()) return true; Do we have an isolate pointer here? Don't we need to add something like i::Isolate* isolate = i::Isolate::Current(); above? Actually, judging from Issue 1780 this check seems to be placed in the wrong method, it should be in the method below (LowMemoryNotification), but I think it would be nice to have it in both. http://codereview.chromium.org/8347032/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
