LGTM with comments.
http://codereview.chromium.org/8345038/diff/1/src/api.cc File src/api.cc (right): http://codereview.chromium.org/8345038/diff/1/src/api.cc#newcode3099 src/api.cc:3099: &ignored); I thought we had a convention that we put each argument in a separate line if they all do not fit in single line. http://codereview.chromium.org/8345038/diff/1/src/objects.cc File src/objects.cc (right): http://codereview.chromium.org/8345038/diff/1/src/objects.cc#newcode539 src/objects.cc:539: Handle<Object> Object::GetProperty(Handle<Object> object, On 2011/10/19 07:20:30, Kevin Millikin wrote:
I can't decide if I like the isolate argument or not. It seems a bit
nicer that
the caller doesn't have to worry about it. What do you think?
We are using an implicit invariant that the 'isolate_' member of all IC and stub compilers is equal to the expression below. If the invariant will stay valid in future (i.e. other people cannot accidentally break it), then I would also prefer to drop the isolate argument. http://codereview.chromium.org/8345038/diff/1/src/runtime.cc File src/runtime.cc (right): http://codereview.chromium.org/8345038/diff/1/src/runtime.cc#newcode8133 src/runtime.cc:8133: JSFunction::CompileLazy(function, CLEAR_EXCEPTION); Do we assume after this line that the function is compiled regardless of CompileLazy result? http://codereview.chromium.org/8345038/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
