LGTM with a nit, which should probably be addressed in a separate CL
http://codereview.chromium.org/8342032/diff/3/src/arm/code-stubs-arm.cc File src/arm/code-stubs-arm.cc (right): http://codereview.chromium.org/8342032/diff/3/src/arm/code-stubs-arm.cc#newcode7391 src/arm/code-stubs-arm.cc:7391: __ Pop(r2, r3); Not introduced by this CL, but anyway: Our ARM macro-assembler should really have symmetrical push/pop instructions. Currently, we are able to push e.g. 4 registers in a single instruction, but pop only 2. Note that we have to be careful with the argument order to get good code. http://codereview.chromium.org/8342032/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
