http://codereview.chromium.org/8357004/diff/4001/src/flag-definitions.h File src/flag-definitions.h (right):
http://codereview.chromium.org/8357004/diff/4001/src/flag-definitions.h#newcode531 src/flag-definitions.h:531: DEFINE_bool(trace_element_transitions, false, "print element transitions") On 2011/10/19 16:02:28, Jakob wrote:
For consistency, I'd prefer to have the plural form "elements"
everywhere. Done. http://codereview.chromium.org/8357004/diff/4001/src/objects.cc File src/objects.cc (right): http://codereview.chromium.org/8357004/diff/4001/src/objects.cc#newcode1126 src/objects.cc:1126: PrintF("elements transition ["); On 2011/10/19 16:02:28, Jakob wrote:
It doesn't make a difference for the current usage of this method, but
since it
does take a FILE* parameter for the output file, it would make sense
to print
*all* output to |file| using PrintF(FILE* out, const char* format,
...). Done. http://codereview.chromium.org/8357004/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
