Thanks!! On Thu, Oct 20, 2011 at 11:28 AM, <[email protected]> wrote:
> LGTM. > > Committed as r9718, using code review http://codereview.chromium.** > org/8352040/ <http://codereview.chromium.org/8352040/>. > > Sorry it took so long. > > > http://codereview.chromium.**org/7489045/diff/27001/src/** > ia32/lithium-codegen-ia32.cc<http://codereview.chromium.org/7489045/diff/27001/src/ia32/lithium-codegen-ia32.cc> > File src/ia32/lithium-codegen-ia32.**cc (right): > > http://codereview.chromium.**org/7489045/diff/27001/src/** > ia32/lithium-codegen-ia32.cc#**newcode1559<http://codereview.chromium.org/7489045/diff/27001/src/ia32/lithium-codegen-ia32.cc#newcode1559> > src/ia32/lithium-codegen-ia32.**cc:1559: __ cmp(ToOperand(left), > ToImmediate(right)); > If the immediate value is 0, this can also be test(left, left) on ia32 > and x64. You should try this on ARM, if possible. I'll test it on ia32 > and x64. Also, this can be a ToRegister(left) (fixed). > > http://codereview.chromium.**org/7489045/diff/27001/src/** > x64/lithium-codegen-x64.cc<http://codereview.chromium.org/7489045/diff/27001/src/x64/lithium-codegen-x64.cc> > File src/x64/lithium-codegen-x64.cc (right): > > http://codereview.chromium.**org/7489045/diff/27001/src/** > x64/lithium-codegen-x64.cc#**newcode1565<http://codereview.chromium.org/7489045/diff/27001/src/x64/lithium-codegen-x64.cc#newcode1565> > src/x64/lithium-codegen-x64.**cc:1565: __ cmpl(ToRegister(left), > ToOperand(right)); > The register and memory operand cases for right must be handled > separately. ToOperand does not work for registers on x64 platform. > Fixed. > > http://codereview.chromium.**org/7489045/<http://codereview.chromium.org/7489045/> > -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
