Reviewers: Kevin Millikin, Message: Please take a look.
http://codereview.chromium.org/8356041/diff/1/src/ic.cc File src/ic.cc (right): http://codereview.chromium.org/8356041/diff/1/src/ic.cc#newcode1492 src/ic.cc:1492: if (!receiver_maps->at(current).is_null() && Unfortunately, receiver_maps can contain nulls (see line 1667). http://codereview.chromium.org/8356041/diff/1/src/ic.cc#newcode1514 src/ic.cc:1514: for (RelocIterator it(*stub, mask); !it.done(); it.next()) { Is it possible to handlify the iterator? http://codereview.chromium.org/8356041/diff/1/src/ic.cc#newcode1667 src/ic.cc:1667: transitioned_maps.Add(transitioned_map); transitioned_map can be null. http://codereview.chromium.org/8356041/diff/1/src/stub-cache.cc File src/stub-cache.cc (right): http://codereview.chromium.org/8356041/diff/1/src/stub-cache.cc#newcode622 src/stub-cache.cc:622: MapList raw_receiver_maps(receiver_maps->length()); I am not happy with the following 12 lines, but can't think of a better way. Description: Handlify KeyedIC::ComputeStub. BUG= TEST= Please review this at http://codereview.chromium.org/8356041/ SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge Affected files: M src/ic.h M src/ic.cc M src/list-inl.h M src/list.h M src/objects.h M src/objects.cc M src/stub-cache.h M src/stub-cache.cc -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
