Possibly. I'm a bit nervous, because Handle<Smi>::null() and Handle<Smi>(Smi::FromInt(0)) seem like different things.
On Fri, Oct 21, 2011 at 10:45 AM, <[email protected]> wrote: > DBC: > > > > http://codereview.chromium.**org/8356041/diff/1/src/ic.cc<http://codereview.chromium.org/8356041/diff/1/src/ic.cc> > File src/ic.cc (right): > > http://codereview.chromium.**org/8356041/diff/1/src/ic.cc#**newcode1492<http://codereview.chromium.org/8356041/diff/1/src/ic.cc#newcode1492> > src/ic.cc:1492: if (!receiver_maps->at(current).**is_null() && > On 2011/10/20 14:35:54, ulan wrote: > >> Unfortunately, receiver_maps can contain nulls (see line 1667). >> > > If we have to check for null-handles in a lot of places, I'd consider > removing the debug-mode assert in the *-operator that checks for NULL. > It does not help much in debugging IMO. What do you guys think? > > http://codereview.chromium.**org/8356041/<http://codereview.chromium.org/8356041/> > -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
