[v8-dev] Re: Refactor and clean up array allocation across platforms. (issue 8359034)

Mon, 24 Oct 2011 01:00:43 -0700 

Couple of quick comments to improve it.


http://codereview.chromium.org/8359034/diff/1/src/arm/builtins-arm.cc
File src/arm/builtins-arm.cc (right):

http://codereview.chromium.org/8359034/diff/1/src/arm/builtins-arm.cc#newcode99
src/arm/builtins-arm.cc:99: int initial_capacity =
JSArray::kPreallocatedArrayElements;
Drive by:

Make this a const, and make the asserts that use it into STATIC_ASSERT
where possible.

http://codereview.chromium.org/8359034/diff/1/src/arm/builtins-arm.cc#newcode185
src/arm/builtins-arm.cc:185: __ b(ne, &not_empty);
Drive by:

You can replace all this with:

if (FLAG_debug_code) {
  __ tst(array_size, array_size);
  __ Assert(ne, "array size is unexpectedly 0");
}

http://codereview.chromium.org/8359034/

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to