LGTM
http://codereview.chromium.org/8381003/diff/1/src/serialize.cc File src/serialize.cc (right): http://codereview.chromium.org/8381003/diff/1/src/serialize.cc#newcode760 src/serialize.cc:760: Address address) { When is address passed as NULL? Why? I.e., please put some documentation on this function in the .h file - at least what the parameters mean and what values they may assume. http://codereview.chromium.org/8381003/diff/1/src/serialize.cc#newcode808 src/serialize.cc:808: Address address = external_reference_decoder_-> \ Could we call this variable something else, so it doesn't have the same name as the function parameter. http://codereview.chromium.org/8381003/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
