Turns out my changes were not well tested to begin with. I added some tests
and
fixed the issues.
The null embedding has been fixed by an additional loop doing a replace. It
is
still faster this way. I gathered some data. Using WriteAscii on a cons with
length 2^28 and 28 levels, the old version takes 1780ms, the new version
takes
1140ms. When using WriteAscii on a cons with length 2^8 and 8 levels a
total of
2^20 times, the old version takes 1700ms, the new version takes 990ms.
http://codereview.chromium.org/8390004/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
