LGTM, but I really think the stack grows upward.

http://codereview.chromium.org/8403037/diff/1/src/isolate.h
File src/isolate.h (right):

http://codereview.chromium.org/8403037/diff/1/src/isolate.h#newcode1249
src/isolate.h:1249: bool IsAboveFrame(JavaScriptFrame* frame) {
Let's rename this to use "Below", and you can change the comment to say:

Returns true if this save context is below a given JavaScript frame
(i.e., at a higher address).

http://codereview.chromium.org/8403037/

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to