LGTM. I like tests. It currently fails with the recent fixes to assertSame, so
please add it to mjsunit.status in case it still fails when landing.


http://codereview.chromium.org/8392038/diff/1/test/mjsunit/harmony/proxies-example-membrane.js
File test/mjsunit/harmony/proxies-example-membrane.js (right):

http://codereview.chromium.org/8392038/diff/1/test/mjsunit/harmony/proxies-example-membrane.js#newcode32
test/mjsunit/harmony/proxies-example-membrane.js:32: //
http://wiki.ecmascript.org/doku.php?id=harmony:proxies#examplea_no-op_forwarding_proxy
I am not sure about the policy for long URLs in comments. If it is OK to
have more than 80 chars per line here then I am fine with it.

http://codereview.chromium.org/8392038/diff/1/test/mjsunit/harmony/proxies-example-membrane.js#newcode284
test/mjsunit/harmony/proxies-example-membrane.js:284: //
http://wiki.ecmascript.org/doku.php?id=harmony:proxies#an_identity-preserving_membrane
Likewise.

http://codereview.chromium.org/8392038/

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to