LGTM with nits.

http://codereview.chromium.org/8423005/diff/1/src/scopes.h
File src/scopes.h (right):

http://codereview.chromium.org/8423005/diff/1/src/scopes.h#newcode56
src/scopes.h:56: InitializationFlag);
s/InitializationFlag/InitializationFlag initialization_flag/

http://codereview.chromium.org/8423005/diff/1/src/v8globals.h
File src/v8globals.h (right):

http://codereview.chromium.org/8423005/diff/1/src/v8globals.h#newcode573
src/v8globals.h:573: // properties of some object. In the specification
only mutable bindings exists
nit: s/exists/exist/

http://codereview.chromium.org/8423005/diff/1/src/variables.h
File src/variables.h (right):

http://codereview.chromium.org/8423005/diff/1/src/variables.h#newcode81
src/variables.h:81: InitializationFlag initialization_flag_);
nit: no trailing underscore

http://codereview.chromium.org/8423005/

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to