[v8-dev] [v8] r9858 committed - Remove one-line helper used in two places....

Tue, 01 Nov 2011 05:26:16 -0700 

Revision: 9858
Author:   [email protected]
Date:     Tue Nov  1 05:25:18 2011
Log:      Remove one-line helper used in two places.
Review URL: http://codereview.chromium.org/8387067
http://code.google.com/p/v8/source/detail?r=9858

Modified:
 /branches/bleeding_edge/src/arm/full-codegen-arm.cc
 /branches/bleeding_edge/src/ia32/full-codegen-ia32.cc
 /branches/bleeding_edge/src/mips/full-codegen-mips.cc
 /branches/bleeding_edge/src/x64/full-codegen-x64.cc

=======================================
--- /branches/bleeding_edge/src/arm/full-codegen-arm.cc Mon Oct 31 02:38:52 2011 +++ /branches/bleeding_edge/src/arm/full-codegen-arm.cc Tue Nov 1 05:25:18 2011 
@@ -47,11 +47,6 @@
 #define __ ACCESS_MASM(masm_)


-static unsigned GetPropertyId(Property* property) {
-  return property->id();
-}
-
-
// A patch site is a location in the code which it is possible to patch. This // class has a number of methods to emit the code which is patchable and the 
 // method EmitPatchInfo to record a marker back to the patchable code. This
@@ -1734,7 +1729,7 @@
   __ mov(r2, Operand(key->handle()));
   // Call load IC. It has arguments receiver and property name r0 and r2.
   Handle<Code> ic = isolate()->builtins()->LoadIC_Initialize();
-  __ Call(ic, RelocInfo::CODE_TARGET, GetPropertyId(prop));
+  __ Call(ic, RelocInfo::CODE_TARGET, prop->id());
 }


@@ -1742,7 +1737,7 @@
   SetSourcePosition(prop->position());
   // Call keyed load IC. It has arguments key and receiver in r0 and r1.
   Handle<Code> ic = isolate()->builtins()->KeyedLoadIC_Initialize();
-  __ Call(ic, RelocInfo::CODE_TARGET, GetPropertyId(prop));
+  __ Call(ic, RelocInfo::CODE_TARGET, prop->id());
 }


=======================================
--- /branches/bleeding_edge/src/ia32/full-codegen-ia32.cc Tue Nov 1 05:20:46 2011 +++ /branches/bleeding_edge/src/ia32/full-codegen-ia32.cc Tue Nov 1 05:25:18 2011 
@@ -44,11 +44,6 @@
 #define __ ACCESS_MASM(masm_)


-static unsigned GetPropertyId(Property* property) {
-  return property->id();
-}
-
-
 class JumpPatchSite BASE_EMBEDDED {
  public:
   explicit JumpPatchSite(MacroAssembler* masm) : masm_(masm) {
@@ -1636,14 +1631,14 @@
   ASSERT(!key->handle()->IsSmi());
   __ mov(ecx, Immediate(key->handle()));
   Handle<Code> ic = isolate()->builtins()->LoadIC_Initialize();
-  __ call(ic, RelocInfo::CODE_TARGET, GetPropertyId(prop));
+  __ call(ic, RelocInfo::CODE_TARGET, prop->id());
 }


 void FullCodeGenerator::EmitKeyedPropertyLoad(Property* prop) {
   SetSourcePosition(prop->position());
   Handle<Code> ic = isolate()->builtins()->KeyedLoadIC_Initialize();
-  __ call(ic, RelocInfo::CODE_TARGET, GetPropertyId(prop));
+  __ call(ic, RelocInfo::CODE_TARGET, prop->id());
 }


=======================================
--- /branches/bleeding_edge/src/mips/full-codegen-mips.cc Mon Oct 31 02:38:52 2011 +++ /branches/bleeding_edge/src/mips/full-codegen-mips.cc Tue Nov 1 05:25:18 2011 
@@ -55,11 +55,6 @@
 #define __ ACCESS_MASM(masm_)


-static unsigned GetPropertyId(Property* property) {
-  return property->id();
-}
-
-
// A patch site is a location in the code which it is possible to patch. This // class has a number of methods to emit the code which is patchable and the 
 // method EmitPatchInfo to record a marker back to the patchable code. This
@@ -1748,7 +1743,7 @@
   __ li(a2, Operand(key->handle()));
   // Call load IC. It has arguments receiver and property name a0 and a2.
   Handle<Code> ic = isolate()->builtins()->LoadIC_Initialize();
-  __ Call(ic, RelocInfo::CODE_TARGET, GetPropertyId(prop));
+  __ Call(ic, RelocInfo::CODE_TARGET, prop->id());
 }


@@ -1757,7 +1752,7 @@
   __ mov(a0, result_register());
   // Call keyed load IC. It has arguments key and receiver in a0 and a1.
   Handle<Code> ic = isolate()->builtins()->KeyedLoadIC_Initialize();
-  __ Call(ic, RelocInfo::CODE_TARGET, GetPropertyId(prop));
+  __ Call(ic, RelocInfo::CODE_TARGET, prop->id());
 }


=======================================
--- /branches/bleeding_edge/src/x64/full-codegen-x64.cc Mon Oct 31 02:38:52 2011 +++ /branches/bleeding_edge/src/x64/full-codegen-x64.cc Tue Nov 1 05:25:18 2011 
@@ -44,11 +44,6 @@
 #define __ ACCESS_MASM(masm_)


-static unsigned GetPropertyId(Property* property) {
-  return property->id();
-}
-
-
 class JumpPatchSite BASE_EMBEDDED {
  public:
   explicit JumpPatchSite(MacroAssembler* masm) : masm_(masm) {
@@ -1688,14 +1683,14 @@
   Literal* key = prop->key()->AsLiteral();
   __ Move(rcx, key->handle());
   Handle<Code> ic = isolate()->builtins()->LoadIC_Initialize();
-  __ call(ic, RelocInfo::CODE_TARGET, GetPropertyId(prop));
+  __ call(ic, RelocInfo::CODE_TARGET, prop->id());
 }


 void FullCodeGenerator::EmitKeyedPropertyLoad(Property* prop) {
   SetSourcePosition(prop->position());
   Handle<Code> ic = isolate()->builtins()->KeyedLoadIC_Initialize();
-  __ call(ic, RelocInfo::CODE_TARGET, GetPropertyId(prop));
+  __ call(ic, RelocInfo::CODE_TARGET, prop->id());
 }


--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to