LGTM if you confirm that the two things I commented on were done on purpose.
http://codereview.chromium.org/8351073/diff/1/tools/gyp/v8.gyp File tools/gyp/v8.gyp (right): http://codereview.chromium.org/8351073/diff/1/tools/gyp/v8.gyp#newcode30 tools/gyp/v8.gyp:30: 'target_conditions': [ Note that these settings will not be applied to d8, cctest and any other targets not defined in this file. If you want to build those for Android, too, please move this target_condition to ../../build/common.gypi. http://codereview.chromium.org/8351073/diff/1/tools/gyp/v8.gyp#newcode748 tools/gyp/v8.gyp:748: 'v8_base', Since v8_nosnapshot depends on v8_base anyway, I don't see why this addition is necessary. http://codereview.chromium.org/8351073/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
