LGTM
http://codereview.chromium.org/8477030/diff/1/SConstruct File SConstruct (right): http://codereview.chromium.org/8477030/diff/1/SConstruct#newcode97 SConstruct:97: 'CCFLAGS': ['-O3', '-g'], You probably do not want to commit this. http://codereview.chromium.org/8477030/diff/1/src/heap-inl.h File src/heap-inl.h (right): http://codereview.chromium.org/8477030/diff/1/src/heap-inl.h#newcode58 src/heap-inl.h:58: RelocateQueueHead(); This one asserts that there is something to relocate. http://codereview.chromium.org/8477030/diff/1/src/heap.h File src/heap.h (right): http://codereview.chromium.org/8477030/diff/1/src/heap.h#newcode300 src/heap.h:300: delete emergency_stack_; I would be more comfortable if you also nulled it. Perhaps also assert that it is empty. http://codereview.chromium.org/8477030/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
