lgtm if you address comments
http://codereview.chromium.org/8372064/diff/1/src/elements.cc File src/elements.cc (right): http://codereview.chromium.org/8372064/diff/1/src/elements.cc#newcode79 src/elements.cc:79: static Failure* ArrayLengthRangeError(Heap* heap) { Call this ThrowArrayLengthRangeError http://codereview.chromium.org/8372064/diff/1/src/elements.cc#newcode388 src/elements.cc:388: obj->GetElementsKind() == FAST_SMI_ONLY_ELEMENTS Use obj->HasFastSmiOnlyElements() http://codereview.chromium.org/8372064/diff/1/src/elements.cc#newcode549 src/elements.cc:549: { MaybeObject* maybe_obj = array->ResetElements(); This weird formatting is an artifact of an automated GC-related change that went in a long time ago. Take this opportunity to remove the unneeded extra scope and clean this up. http://codereview.chromium.org/8372064/diff/1/src/elements.cc#newcode882 src/elements.cc:882: if (!maybe_object->To(&dictionary)) return maybe_object; remove extra scope http://codereview.chromium.org/8372064/diff/1/src/elements.cc#newcode899 src/elements.cc:899: { MaybeObject* maybe_obj = array->GetHeap()->AllocateFixedArray(1); prune extra scope http://codereview.chromium.org/8372064/diff/1/src/elements.cc#newcode904 src/elements.cc:904: { MaybeObject* maybe_obj = array->EnsureCanContainElements(&length, 1); prune extra scope http://codereview.chromium.org/8372064/diff/1/src/elements.cc#newcode909 src/elements.cc:909: array->set_elements(new_backing_store); Consider using array->SetContent to simplify the previous several lines. http://codereview.chromium.org/8372064/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
