LGTM with a comment. I'd also remove empty BUG= and TEST= from the description.
http://codereview.chromium.org/8507008/diff/1/src/platform-linux.cc File src/platform-linux.cc (right): http://codereview.chromium.org/8507008/diff/1/src/platform-linux.cc#newcode1009 src/platform-linux.cc:1009: #elif V8_HOST_ARCH_MIPS On 2011/11/09 11:36:05, Yang wrote:
On 2011/11/09 11:26:22, Mikhail Naganov (Chromium) wrote: > Does it compile at all? Looks simply incorrect as #elif hangs alone
w/o #if
I think this #elif refers to the #if V8_HOST_ARCH_IA32 in line 990.
Ah, that's right. I'd recommend adding a comment like "// __GLIBC__ version check" to the #endif above to avoid confusion. http://codereview.chromium.org/8507008/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
